laptop-mode-tools icon indicating copy to clipboard operation
laptop-mode-tools copied to clipboard

Linux 4.11 ASPM powersupersave mode

Open mlen opened this issue 7 years ago • 6 comments

4.11 kernel introduced new ASPM mode which should be used in pcie-aspm hook if the support for is detected. Probably it'd be nicer to allow to configure the mode to use on ac and on battery, so that users can choose the right mode for them

mlen avatar May 05 '17 12:05 mlen

Are you referring to these recent changes ?

rickysarraf avatar May 06 '17 07:05 rickysarraf

Yes, exactly.

mlen avatar May 06 '17 09:05 mlen

Having ASPM_BATTERY_POLICY and ASPM_AC_POLICY configuration variables would be ideal for me

mlen avatar May 06 '17 20:05 mlen

IIRC, I did explore those power saving attributes. But the improvements weren't substantial. But I'll revisit it again, soon.

Regarding BATT and AC tunables, yes, it'd be nice to have them. If you already have a patch, please do submit it here.

rickysarraf avatar May 09 '17 06:05 rickysarraf

I don't have a patch yet, for now I just patched the script locally. I'll take a look at this again some time later (probably in June), because -ENOTIME

mlen avatar May 09 '17 19:05 mlen

Having ASPM_BATTERY_POLICY and ASPM_AC_POLICY configuration variables would be ideal for me

I second that it would be great to have these options.

With my laptop I ran into the same issue as described here: https://bugzilla.kernel.org/show_bug.cgi?id=215832#c38 That is, powersave results in battery drain in s2idle, but using powersupersave solves the problem.

Hence it would be great to tell laptop-mode-tools to use powersupersave.

With the lack of an option to set this policy is there a workaround to tell laptop-mode-tools to use powersupersave?

robbertkrebbers avatar Oct 29 '23 10:10 robbertkrebbers