Rick Staa

Results 1034 comments of Rick Staa

@rsk2 I planned to change all files since es6 imports/exports are now recommended. So unless the change breaks something, which I don't suspect, no files need to be excluded.

Amazing! The most basic way would be to execute `npm run tests` https://github.com/anuraghazra/github-readme-stats/blob/579cb7d175d09c4d2c24742a331134e4ed8f027b/package.json#L7 I, however, always use the following VsCode extensions to run and debug them: - https://marketplace.visualstudio.com/items?itemName=hbenl.vscode-test-explorer - https://marketplace.visualstudio.com/items?itemName=kavod-io.vscode-jest-test-adapter...

@rsk2 Ah, I think that is because jest does not yet natively support es modules, and we have the test folder outside of the main module (see https://jestjs.io/docs/ecmascript-modules). However, I...

@rsk2 Ah, sorry, I overlooked that problem. 😅 Like I said in typescript all the heavy lifting to make this possible is done by ts-jest. The only solution would be...

@Rudxain Thanks for wanting to contribute. I think @rsk2 is already done implementing this feature but runs into https://github.com/anuraghazra/github-readme-stats/issues/1955#issuecomment-1231933253. Do you know a solution other than https://github.com/anuraghazra/github-readme-stats/issues/1955#issuecomment-1232100954 that might work?...

@rsk2 Thanks for letting me know. I just tried fixing these errors myself (see https://github.com/anuraghazra/github-readme-stats/tree/change_to_es_imports), but I keep getting the following errors: ```error SyntaxError: The requested module '@testing-library/dom' does not...

@rsk2 I managed to do this in an example repository https://github.com/rickstaa/es6-jest-example. So now the only thing left is where https://github.com/anuraghazra/github-readme-stats/tree/change_to_es_imports differs from this example repo.

@rsk2 Okay, I fixed those errors and found the right combination of dependencies (see https://github.com/anuraghazra/github-readme-stats/tree/change_to_es_imports). Two small jest errors still have to be fixed and the code has to be...

@rsk2 I managed to fix all ES6-related errors. 🎉 I will fix 2 unrelated issues and clean up the code a bit. I will create a PR on your branch...

@rsk2 I just created https://github.com/rsk2/github-readme-stats/pull/1 to fix the errors you're having. Feel free to merge it and make a PR to https://github.com/anuraghazra/github-readme-stats.