Rick Ossendrijver

Enable checks from Error Prone Support

7

In PR https://github.com/checkstyle/checkstyle/pull/14136 I added Error Prone Support to Checkstyle. As @romani suggested in https://github.com/checkstyle/checkstyle/issues/14129, I'd like to create this issue to discuss which checks from [Error Prone Support](https://github.com/picnicSupermarket/error-prone-support/) are...

Introduce generic `run-integration-test.sh` script

4

This PR aims to split out some of the changes from #894 to minimize the diff of that PR. It's introducing too many changes to review at once. After we...

Rewrite `Optional.of(A).orElse(B)` to `requireNonNull(A)`

3

### Problem As @EnricSala mentioned in https://github.com/PicnicSupermarket/error-prone-support/issues/364, we might want to investigate rewriting `Optional.of(A).orElse(B)` to `requireNonNull(A)`. This will probably require a `BugChecker` as we probably want to provide two fixes,...

Canonical constant naming

8

### Problem According to the [Google Java Format Style guide](https://google.github.io/styleguide/javaguide.html) constants names [should use](https://google.github.io/styleguide/javaguide.html#s5.2.4-constant-names) `UPPER_SNAKE_CASE`. There is a [`ConstantField`](http://errorprone.info/bugpattern/ConstantField) check in Error Prone that does the following: > When naming...

### Problem In https://github.com/checkstyle/checkstyle/pull/14229 we are enabling the `CollectorMutability` check in the Checkstyle repository. The Checkstyle team tries to minimize the dependencies they have on Guava. Therefore, the rewrite to...

### Problem For every Refaster Rule collection we have a corresponding `*Test{Input,Output}.java` file where we test the Refaster rules. These test classes implement the `RefasterRuleCollectionTestCase` interface that contains the `elidedTypesAndStaticImports`...

Canonical SLF4J Logger usage

4

### Problem Internally we heavily use SLF4J for logging in our classes. We would like to have a check to canonicalize the usage of such loggers. For that reason we...

Add type arguments in `@AfterTemplate`s for builders

6

While applying `error-prone-support` on repositories within Picnic we found that for some templates we lose generic type information. Therefore, we opened a PR upstream https://github.com/google/error-prone/pull/2706 to fix this. The problem...

### Problem We want to sort the order of the members in a class. Internally we are quite strict with our ordering for the sake of consistency. The following order...

Prefer `BugCheckerRefactoringTestHelper#doTest(TestMode.TEXT_MATCH)` over alternatives

6

### Problem This is specific to the `BugCheckerRefactoringTestHelper` which is used in [replacement tests](https://github.com/PicnicSupermarket/error-prone-support/blob/master/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/EmptyMethodTest.java#L71-L92) for BugPatterns. There are two `TestMode`s, namely `AST_MATCH` and `TEXT_MATCH`. During multiple code reviews we noticed...