Rick Ossendrijver

Results 67 comments of Rick Ossendrijver

As @Badbond mentioned in the internal upgrade PR, we probably also want to wait for the support in `mvnd`. This is the most recent milestone that will update it to...

I'll add the `pause renovate` :).

Hey @msridhar, on your branch https://github.com/msridhar/NullAway/commit/7c8ac63ab855c9bd84a843a9e7feb92f044d62fd#diff-d8162adf8ce392acc05a12713ac761cde51b50b4250a3d408cb04e66ee8ec85aR78 I see some checks are [disabled](https://github.com/msridhar/NullAway/commit/7c8ac63ab855c9bd84a843a9e7feb92f044d62fd#diff-d8162adf8ce392acc05a12713ac761cde51b50b4250a3d408cb04e66ee8ec85aR77-R81). I can imagine most of these checks are quite opinionated and therefore may be less useful. However, I'm...

That makes sense. Good to know, thanks 😄!

Hi! > I've noticed that to solve this issue, the only global variables that need this change are the private static final long `serialVersionUID`. Is this issue still relevant? Even...

Hi @BLasan , yes it is! @mohamedsamehsalah is working on it in https://github.com/PicnicSupermarket/error-prone-support/pull/794. You would like to work on a ticket of Error Prone Support or are you interested in...

Hi @BLasan , I created a ticket that is a nice introduction to get started with Refaster: https://github.com/PicnicSupermarket/error-prone-support/issues/1001. I'd say, give it a go and let us know if you...

Thanks for pointing out, forgot to mention that. The [implementation](https://github.com/google/error-prone/blob/master/test_helpers/src/main/java/com/google/errorprone/BugCheckerRefactoringTestHelper.java#L242-L244) of `.doTest()` delegates to `.doTests(TestMode.AST_MATCH)`.

Tweaked the ticket to also cover the following rewrite: `BugCheckerRefactoringTestHelper.TestMode.TEXT_MATCH` --> `TestMode.TEXT_MATCH`.

Hi @ksiczek, thanks for taking the time to report an issue! This sure looks like a bug and should be fixed. The thing is that Lombok probably generates extra parentheses...