hyperterm-overlay icon indicating copy to clipboard operation
hyperterm-overlay copied to clipboard

Show Hyper on top of fullscreen apps

Open iammenasco opened this issue 7 years ago • 9 comments

Setting win.setAlwaysOnTop to true is not enough to allow Hyper to show up on top of full screen apps. We need to pass in the optional 'level' parameter.

iammenasco avatar May 05 '17 15:05 iammenasco

Looking at BrowserWindow docs, the screen (only) parameter not exists for setAlwaysOnTop. https://electron.atom.io/docs/api/browser-window/#winsetalwaysontopflag-level-relativelevel

rickgbw avatar May 05 '17 17:05 rickgbw

Bump! Would really love to see this!

mattapperson avatar Jun 23 '17 03:06 mattapperson

FWIW I will gladly help make any needed changes to get this merged

mattapperson avatar Jun 23 '17 03:06 mattapperson

I read an article that said passing screen would do the trick, but looks like its not on the official  documentation. I haven't been able to look into other parameters that would accomplish this, though it seemed to be fine during development...

iammenasco avatar Jun 26 '17 14:06 iammenasco

FWIW The following fixed it for me:

if ( this._config.alwaysOnTop && ! this._config.primaryDisplay ) {
	this._app.dock.hide();
	win.setVisibleOnAllWorkspaces(true);
	win.setFullScreenable(false);
}

shadyvb avatar Apr 21 '18 23:04 shadyvb

@shadyvb I made this fix to my overlay.js. However, there is a small gap between the top of the screen and the top of the hyper window when using hyper-overlay over a full screen app. The gap size is the same size of the topbar in osx. Is their a way to conditionally push up the hyper window when displaying it over fullscreen apps?

jcristol avatar Jul 25 '18 19:07 jcristol

Unfortunately I've been having the same, and it even extends to the first line or two in the terminal, very annoying when you try copying stuff from those first couple of lines. A small price to pay to get all the awesomeness I guess!

shadyvb avatar Jul 25 '18 23:07 shadyvb

It was bothering me so I pinned the hyper window to the bottom of my screen. No top bar to contend with.

jcristol avatar Jul 25 '18 23:07 jcristol

Nice! Never thought of that!

shadyvb avatar Jul 26 '18 01:07 shadyvb