Rick Beton
Rick Beton
This is a good idea, but a breaking change. ( So make a v2! :-D )
BTW in my experience, low compression levels are better than the defaults for this kind of use case; level 4 is used in the suggested code here. This amends `ForceApi.request`:...
I would have made a PR but when I checked out the code I got many test failures.
BTW the suggested code above uses the standard `encoding/json` package instead of the `forcejson` package. I'm not clear why `forcejson` exists, but if it's really needed it should have `NewEncoder`...
I created a fork which works for me: PR #68 The important changes are: * created a v2 code folder and moved the v2 code into it * reverted the...
Perhaps the last v1 code ought to be re-instated in the top-level folder. Also, it is possible to handle v2, v3 ... etc using tags instead of folders. See https://blog.golang.org/v2-go-modules
Surely `Shift(-2)` and `Shift(2)` are better expressions for converting to/from percent.
This really is debatable. In principle I would agree. However, the Go standard library has widespread use of `var` "constants" (that are not constant) and all sorts of things will...
(aside: ideally Go would have immutable values that would allow such `var` expressions to be really constant; however the language does not have this capability)
Gentle nudge, Pavel @psergee - you can merge this now. :-)