NoSleep.js icon indicating copy to clipboard operation
NoSleep.js copied to clipboard

Fix #134 #135 #136

Open alebianco-doxee opened this issue 3 years ago • 15 comments

This PR contains a:

  • [x] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

Fixes NoSleep not working in recent iOS versions with the solution found by @z-x https://github.com/richtr/NoSleep.js/issues/135 https://github.com/richtr/NoSleep.js/issues/136

Also fixes NoSleep not working on Samsung Browser due to permission denied error https://github.com/richtr/NoSleep.js/issues/134

alebianco-doxee avatar Nov 22 '21 08:11 alebianco-doxee

Thanks!

z-x avatar Nov 22 '21 12:11 z-x

It would be amazing if this fix is merged soon into a 0.12.1 patch version or so. We've also quite a lot of iOS users recently complaining that the screen goes black while using our App. Thanks for your work guys!

Moongazer avatar Nov 22 '21 15:11 Moongazer

I can confirm this fixed NoSleep.js on iOS 15.1 in my app.

CodeCommander avatar Dec 08 '21 23:12 CodeCommander

@richtr Any way to merge it?

zamarawka avatar Dec 13 '21 18:12 zamarawka

Hey guys, it will be perfect if it will be merged 🙌

Romander avatar Dec 14 '21 14:12 Romander

@zamarawka it looks like @richtr has made zero contributions this year.. I wonder if this is a dead repo :(

dcbarans avatar Dec 22 '21 16:12 dcbarans

Since the owner seems dead, I republished it as another package under @uriopass/nosleep.js with version 0.12.1

Uriopass avatar Dec 24 '21 13:12 Uriopass

@Uriopass @alebianco-doxee @z-x @Moongazer @huppfi @CodeCommander @zamarawka @Romander @dcbarans - please, please, please will one of you kind people consider taking this on and creating an "official" fork which we can all come together around? The functionality of nosleep is simply too important not to have a maintained solution (and @richtr definitely seems to have disappeared :( ) - otherwise we are going to end up with a 1000 forks!

If it helps, I am sure some sponsor/patreon/etc. income could be generated for an active repo.

timtribers avatar Jan 04 '22 17:01 timtribers

The fix from #135 breaks Firefox if the script is loaded before the body tag. Appending to body needs to be delayed with something like:

document.addEventListener("DOMContentLoaded", function() { 
  document.querySelector("body").append(this.noSleepVideo);
});

kylemacfarlane avatar Feb 03 '22 12:02 kylemacfarlane

Since the owner seems dead, I republished it as another package under @uriopass/nosleep.js with version 0.12.1

Awesome, thank you! Could you please change the installation instructions in the readme to include the updated package name?

ezekiel747 avatar Jul 18 '22 03:07 ezekiel747

Since the owner seems dead, I republished it as another package under @uriopass/nosleep.js with version 0.12.1

Awesome, thank you! Could you please change the installation instructions in the readme to include the updated package name?

Done :)

Uriopass avatar Aug 17 '22 10:08 Uriopass

I've checked and the Readme file still contains: This package is published to npm as nosleep.js and can be installed with: npm install nosleep.js

ezekiel747 avatar Aug 18 '22 06:08 ezekiel747

Ah sorry you're talking about the npm page! I'll fix this

EDIT: Done

Uriopass avatar Aug 18 '22 07:08 Uriopass

@Uriopass will you update your version?

SUCHiDEV avatar Dec 14 '22 16:12 SUCHiDEV

I don't see what's there to update

Uriopass avatar Dec 15 '22 08:12 Uriopass