Added alert for timeouts

[rubenbristian]

Added alert for timeouts

This is the place where the 500 errors are thrown during the import. From several tests i’ve found out that the items might or not get all through.. So it’s not safe to assume that the import failed completely, because there will still be items loaded until the point where it timed out, and even then, the timeout could happen right at the end..

But if the timeout happens with the last media item, the pages/posts don’t get imported anyway.

So the alert makes the user aware that there COULD (and in 99% cases it’s true) be an error.

[contempoinc]

Nice work, need this badly!

[richtabor]

@contempoinc Have you tested this by chance?

[contempoinc]

@richtabor I haven't

[rubenbristian]

No, “alert” only doesn’t block all execution.. not in this case. I have no idea why.. i can test one more time just to be sure..

Ruben Bristian Co-founder @ KrownThemes

Sent from my phone

On 20 Jun 2018, at 15:43, capuderg [email protected] wrote:

@capuderg commented on this pull request.

In assets/js/merlin.js:

@@ -385,7 +385,12 @@ function ActivateLicense() { }else{ // error - try again with next plugin currentSpan.addClass("status--error");

•            find_next();
  

•            if ( response.status == 500 || response.status == 408 ) {
  

•                var r = confirm(merlin_params.texts.timeout_alert);
  

•                if ( r || ! r ) {
  

hmm... I'm not sure I understand.

Doesn't the confirm (and even alert) JS popup block all execution until the user clicks on one of the options?

So a simple alert should be enough, since the "yes" or "cancel" buttons don't make any difference in execution?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[richtabor]

@rubenbristian Do you have anymore insight on this by chance?

[contempoinc]

It's been a while, but any updates on this? Definitely a much-needed addition.