Richard Megginson

Results 313 comments of Richard Megginson

> If 'kept' does not result in an error? Well, if it works, then it does not result in an error. > > I scanned through the code quickly and...

ok - then how about this? ```yaml firewall_previous: "{{ [] if is_production_environment else [{'previous': 'replaced'}] }}" firewall_settings: - ports: .... firewall: "{{ firewall_previous + firewall_settings }}" ``` that should at...

> This should work. Not as easy as a separate variable, but good enough. > > Should I close this issue, as the "problem" is solveable without additional code or...

@vojtechtrefny @japokorn any ideas?

@vojtechtrefny is the blivet fix available in the latest composes?

> Does anyone know if this storage role works with Amazon Linux 2023? It tries to install Blivet through dnf package manager and fails as it isn't a package on...

For more information, see https://docs.ansible.com/ansible/latest/dev_guide/developing_collections_testing.html and https://docs.ansible.com/ansible/latest/dev_guide/testing_units_modules.html

@tandrez is this related to https://github.com/linux-system-roles/storage/issues/119 ?

> @richm Reading the last comments, it seems to be related indeed. I will update my system to RHEL8.9 and report back. Thanks. @tandrez any luck?

It would be quite difficult to fix this. The problem is the role parameter `firewall` is *the primary role API*. If we just unilaterally change this to e.g. `firewall_config`, *it...