storr icon indicating copy to clipboard operation
storr copied to clipboard

Back-compatible custom key manglers

Open wlandau opened this issue 7 years ago • 5 comments

So far, this PR is just a sketch of https://github.com/richfitz/storr/pull/89#discussion_r230660424. It came together quicker than I predicted. @richfitz, if you agree with implementation, then I will write tests.

wlandau avatar Nov 06 '18 02:11 wlandau

Codecov Report

Merging #90 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files          15       15              
  Lines        1179     1236      +57     
==========================================
+ Hits         1178     1235      +57     
  Misses          1        1
Impacted Files Coverage Δ
R/driver_remote.R 100% <100%> (ø) :arrow_up:
R/utils.R 100% <100%> (ø) :arrow_up:
R/driver_rds.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2750823...d0bb797. Read the comment docs.

codecov-io avatar Nov 06 '18 02:11 codecov-io

This morning, I added bug fixes, tests, and documentation. I think this PR is ready for an initial review.

wlandau avatar Nov 06 '18 13:11 wlandau

Just to let you know - this is absoutely on my radar, but this week has been busy. I will look at this asap

richfitz avatar Nov 08 '18 15:11 richfitz

Thanks, Rich. FYI I will be on vacation from Nov 15 to 27, so I do not expect this work to be fast.

wlandau avatar Nov 09 '18 02:11 wlandau

@richfitz, what are your current thoughts on custom key manglers? Do you still this PR's approach to #88 is a good idea?

wlandau avatar Dec 14 '18 18:12 wlandau