remake icon indicating copy to clipboard operation
remake copied to clipboard

Address #100

Open wlandau opened this issue 9 years ago • 6 comments

I added functions example_remake() and list_examples_remake() to generate and list examples for remake (R/examples.R). I also added testthat tests (tests/testthat/test-examples.R), all of which pass. A call to covr::package_coverage() says that 100% of the code in examples.R is covered in tests.

The file inst/example/README.md has instructions for using and creating examples. To add a new example, simply add a folder in inst/examples with the name of your example. Check the quickstart example for a primer.

I also changed the DESCRIPTION to better accommodate R CMD check --as-cran. I capitalized more words in the title to satisfy the formatting guidelines, and I substituted the entry in authors@R with a call to the person() function.

Lastly, I added .DS_Store and .Rapp.history to .gitignore and .Rbuildignore.

I realize that it may seem a bit forward and presumptuous of me to submit a PR to master. If you would like to decline and then maybe create new separate branch for the next attempt, I can resubmit it there.

wlandau avatar Oct 29 '16 23:10 wlandau

Current coverage is 89.23% (diff: 100%)

Merging #138 into master will increase coverage by 0.03%

@@             master       #138   diff @@
==========================================
  Files            26         27     +1   
  Lines          2324       2331     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2073       2080     +7   
  Misses          251        251          
  Partials          0          0          

Powered by Codecov. Last update 7a70405...af0a2c7

codecov-io avatar Oct 29 '16 23:10 codecov-io

I forgot to mention: I think this PR is ready for review.

wlandau avatar Nov 01 '16 09:11 wlandau

Thanks - I'll get through this soon. I'm still thinking about the interface here though

richfitz avatar Nov 01 '16 09:11 richfitz

Sure, I understand. Just thought I'd say something since I made so many post hoc commits.

wlandau avatar Nov 01 '16 09:11 wlandau

Xref: #54

richfitz avatar Nov 04 '16 08:11 richfitz

Any new thoughts on the interface? If you have something else in mind, maybe I could help.

wlandau avatar Nov 20 '16 18:11 wlandau