Rich FitzJohn

Results 456 comments of Rich FitzJohn

OK, so that's done at the low level: ``` str

Those flags are used only within `src/jq/main.c` and are not part of the libjq interface I think. We don't compile anything from that file into the library

Those are (I think) just flags to `jv_dump_string`, coming through here: https://github.com/ropensci/jqr/blob/e92060a6729fb44a5d9624a253811237bb2c234d/src/jq/jv.h#L188-L199

I think different entry points in jq have different sets of flags. Or I'm confused about what part of the docs you are seeing different sets of flags, perhaps 🎏...

yeah, I think that those are all doing things in `src/jq/main.c` and not part of the library; we'd have to reimplement that in a library style to do that in...

My thoughts: I personally really dislike warnings in R - they're easily lost and don't get printed at a useful time. If it's informational and requires no user action I...

Thanks for the comment - however, I am fairly sure this is a problem and I disagree that moving to tinytest is a reasonable fix for this. To clarify the...

I don't think any of the bits above ran `load_all` on V8 (or did not mean to in any case), just the package under test. Otherwise that all looks about...

I totally agree. It should not actually be that hard though: `apply` is heaps faster: `apply(diamonds, 1, list)` (not _quite_ equivalent) runs in about 0.5s. Exposing whatever underlying code that...

:cry: I didn't even check, but you are of course right. So sad.