Xinnan Wen

Results 11 comments of Xinnan Wen

@howardjohn yep we should actually use the k8s specs under IstioControlPlane, but there are users complain that we claim to still support helm api at this stage so they tend...

@howardjohn I think the problem is that it is not defined in the templates of kiali and tracing, unless they do a k8soverlay

we can unblock it for tracing and kiali toleration first

PTAL @howardjohn

need to wait for the change in api repo: https://github.com/istio/api/pull/1229

@howardjohn I think the motivation here is that validation webhook can do more than openAPI schema check does(basic type, pattern, range checking). So now our custom validation logic is not...

@howardjohn @ayj Yep, that makes sense. I would put this PR on hold for now and move the basic schema checking part to openAPI first.

This may only work if users explicitly define autoscalingv2: false in the IOP spec, which might not be the case most of the time since it servers as an internal...

@howardjohn @ostromart @zirain added two test cases

Thanks for the feedback. for the issue A), that was expected in your case since this function is for migrating 1.4 ca, you already removed citadel so the new cert...