floatl icon indicating copy to clipboard operation
floatl copied to clipboard

Suggestion: option to change class names.

Open meneerprins opened this issue 7 years ago • 3 comments

Would it be possible to add an option to change the class names of the elements? For projects that don't use the CSS BEM method for naming classes but something else it can be very odd.

meneerprins avatar Apr 19 '18 08:04 meneerprins

This is cool with me, but will have to think bout the a API. Do you have any suggestions?

We need to take 5 classnames into account (floatl--focused, floatl--active, floatl--multiline, floatl__label, floatl__input). My first thought is passing in an object as an argument to specify classnames, but this won't look nice and will require a major version bump.

richardvenneman avatar Apr 19 '18 09:04 richardvenneman

Maybe like how choices handles it? https://github.com/jshjohnson/Choices

meneerprins avatar Apr 19 '18 09:04 meneerprins

All right, looks fine. I’d be happy to accept a PR!

Sent from my iPhone

On 19 Apr 2018, at 11:08, Anton Prins [email protected] wrote:

Maybe like how choices handles it? https://github.com/jshjohnson/Choices

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

richardvenneman avatar Apr 19 '18 09:04 richardvenneman