CalendarKit icon indicating copy to clipboard operation
CalendarKit copied to clipboard

When calling DayViewState.move(to:) calendar sometimes skips a week

Open eoy4 opened this issue 6 years ago • 11 comments

What the title says. It sometimes works as expected, others it would scroll briefly to the desired date, and then fast forward one week. I'm just calling dayView.state?.move(to: someDate).

eoy4 avatar Dec 13 '17 03:12 eoy4

The same issue :(

Ihernandezpi avatar Jan 09 '18 17:01 Ihernandezpi

the same issue

sinkync avatar Jan 10 '18 07:01 sinkync

@hevatix, @sinkync I am aware of this issue and will fix it as soon as possible. If you'd like to debug and fix it manually, you may look for false positive Control Loops (by setting breakpoints on the interface methods between multiple modules).

richardtop avatar Jan 10 '18 18:01 richardtop

@richardtop I had already run debug and I think the bug is when TimeLinePagerView Scrollview is trigger when change the date with "moveTo!" I´m not sure how it works but I just comment the line 147 at TimelinPagerView and it works "moveTo" but the pager scroll to change the date doesn't work anymore

Ihernandezpi avatar Jan 10 '18 18:01 Ihernandezpi

@hevatix Thanks for reporting it. Seems, that you've broken one of the control loops. The idea, that all the state changes should go through DayViewState and there should be no loops - the state should act as a "dispatcher" and pass new state information to the other modules.

richardtop avatar Jan 11 '18 18:01 richardtop

Should be fixed in #145

richardtop avatar Apr 04 '18 18:04 richardtop

Still same issues

zungx avatar May 20 '18 07:05 zungx

Same here :( Can you reopen this one?

eoy4 avatar May 20 '18 16:05 eoy4

@richardtop I would love to help fix this issue, now that I am more proficient with Swift. Can you point me in the direction of what I have to look for?

eoy4 avatar Aug 20 '18 16:08 eoy4

@eoy4 in progress in https://github.com/richardtop/CalendarKit/tree/ck-1

richardtop avatar Aug 20 '18 18:08 richardtop

@richardtop this stopped happening to me in latest release. YAY! If others confirm, I think this is fixed.

eoy4 avatar Sep 14 '18 20:09 eoy4