scunpacked icon indicating copy to clipboard operation
scunpacked copied to clipboard

Ship page style tweaks

Open alistair3149 opened this issue 4 years ago • 3 comments

  • Declutter hardpoint table: use darker border, fill empty margin, minor typography tweaks
  • Add hover state to hardpoint table
  • Use gray instead of primary color for stat title since it can be confused with links
  • Slightly decrease the font size of stat title and slightly increase the size for the value
  • Slightly increase the font size of the ship name
  • Use "Description" instead of "CIG says" as heading, syncing with other pages

When this is finalized I will apply the relevant tweaks to other page types.

localhost_4200_ships_aegs_avenger_stalker (1) localhost_4200_ships_aegs_avenger_stalker (2)

alistair3149 avatar Dec 28 '20 00:12 alistair3149

I am having difficulty applying your PRs because they also include all of the other changes you have made.

richardthombs avatar Dec 30 '20 08:12 richardthombs

Hmm that's weird. I didn't include changes from the other PRs in the branch as you can see from the commit on my repo. Does rebasing work?

EDIT: Oh I see. #67 was reverted and it was in master so all my branches was targeting the master that included it. The PR should be mergable if either #67 is merged or merge any of the current PRs since they all included #67

EDIT: I opened #74 that is identical to #67. Merging that to master will restore the branch back to the previous master or you can do a FF if you prefer

alistair3149 avatar Dec 30 '20 13:12 alistair3149

Convert to draft because of rebase

alistair3149 avatar Jan 23 '21 07:01 alistair3149