mockhttp icon indicating copy to clipboard operation
mockhttp copied to clipboard

Add improved VerifyNoOutstandingExpectation messages

Open hwoodiwiss opened this issue 3 years ago • 3 comments

Implementation for #78

hwoodiwiss avatar Feb 13 '22 03:02 hwoodiwiss

I've added tests

@richardszalay would you mind taking a look at this?

hwoodiwiss avatar Feb 23 '22 00:02 hwoodiwiss

Thanks for submitting this PR @hwoodiwiss, and apologies for taking so long to reply.

I'll need to publish this as a major/breaking change release due to the change in the public interfaces, but I think it's worth it.

No worries, and thanks for taking a look!

hwoodiwiss avatar Jul 12 '22 14:07 hwoodiwiss

@richardszalay I've been thinking it over, it might be easiest for now to remove the CallerArgumentExpression stuff, and add that later as a separate feature, what do you think?

hwoodiwiss avatar Jul 21 '22 23:07 hwoodiwiss

Closing this as I've had not had a response from the maintainer in a couple of years (not complaining, people have lives). If anyone else wants to look at implementing something similar in the future, feel free to use/adapt any of the code I've written here as needed.

hwoodiwiss avatar Apr 16 '24 09:04 hwoodiwiss

Apologies for keeping you out of the loop, this functionality (though not this implementation) was included in 7.0.0.

Thanks for understanding re: availability, it's difficult to keep up with side projects when life gets in the way.

Rich

richardszalay avatar Apr 16 '24 09:04 richardszalay

No problem, I'll have to have a play with 7.0.0!

Thank you for the library and the time you give to the community!

hwoodiwiss avatar Apr 16 '24 09:04 hwoodiwiss

Thanks Hugo, and thank you again for the PR. I don't like not merging PRs, but from memory the reason I went for a different implementation is that I decided to also solve for some other usecases.

richardszalay avatar Apr 16 '24 09:04 richardszalay