Richard Schneider
Richard Schneider
I do not like the changes to the unit test. The objects should behave exactly the same as before this PR and no external names should be changed. This is...
@hanabi1224 I really want your changes. It's a good direction for this library. However, PeerTalk test coverage is poor (my fault) so I'm spending a lot of time looking at...
Because testing is poor in `peer-talk`, I built the package with your changes and then included it in `net-ipfs-engine`. The secio changes caused connection with `go-ipfs` to failed. I'll start...
The secio protocol requires fixed 32 big endian length in many places. The code is using varint32. I've tried to note all the cases in my review. Basically, need a...
@vmx, as a C# implementor, I unilaterally decided not to implement these bases. See https://github.com/richardschneider/net-ipfs-core/issues/54