jquery-ui-carousel icon indicating copy to clipboard operation
jquery-ui-carousel copied to clipboard

touch functionality added even though touch:false

Open mdoelker opened this issue 10 years ago • 1 comments

When including the touch plugin, the touch functionality is always initialized when the carousel is created even though the touch option is false.

I think the _create method is lacking a check similar to what can be found in the autoscroll plugin:

_create: function () {

    _super._create.apply(this);

    if (!this.options.touch) { // <-- Hey, I'm new here
        return;
    }

    this._initDrag();

    return;
},

This is on v1.0.2. I'm using { touch: Modernizr && Modernizr.touch } like it was stated in the docs.

mdoelker avatar Apr 15 '14 17:04 mdoelker

Good spot, feel free to send a pull request and I'll merge it in!

richardscarrott avatar May 23 '15 14:05 richardscarrott