Richard Penman

Results 74 comments of Richard Penman
trafficstars

PR welcome to fix this!

Closing as no reply

Do you have an example?

Closing as no reply

Thanks for PR! Looks like some tests are failing: https://github.com/richardpenman/whois/actions/runs/8846370438/job/24292113782?pr=214

The tests don't use live data and the parser will need to be updated to reflect your format changes.

Unfortunately the tests are still failing. You can run tests locally with `python -m pytest` to see what needs fixing.

You’ll need to figure it out. These tests are contributed by multiple people over time. If you’re not motivated that’s fine, I’ll close the PR. On Mon, May 20, 2024...

PR would be welcome to fix the jp TLD

Definitely, you're right that shouldn't be hardcoded. I would gladly accept a PR for this.