BoardBank
BoardBank copied to clipboard
richardneitzke
Add Transaction Log
Hi and thank you for your contribution to this project, I like what you did there!
- I just tested your repo and noticed that the app crashes as soon as transaction values exceed 16 bits ($32,767). Please use Int or Int64 instead of Int16 for storing the balances.
- I noticed that you converted some of my documentation (///) to comments (//). You can check out this post to find out more about why I intentionally used three slashes instead of two.
After you fixed this I would love to merge your pr 🙂
Hi Richard,
Got it, I will change the necessary values and comments. You can expect the commit later this evening.
Best, Miguel
On Sat, Aug 19, 2017 at 3:57 AM, Richard [email protected] wrote:
Hi and thank you for your contribution to this project, I like what you did there!
- I just tested your repo and noticed that the app crashes as soon as transaction values exceed 16 bits ($32,767). Please use Int or Int64 instead of Int16 for storing the balances.
- I noticed that you converted some of my documentation (///) to comments (//). You can check out this post http://zeemboo.com/swift-basics-using-comments-in-swift-code-documentation/ to find out more about why I intentionally used three slashes instead of two.
After you fixed this I would love to merge your pr 🙂
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/richardxyx/BoardBank/pull/8#issuecomment-323508113, or mute the thread https://github.com/notifications/unsubscribe-auth/APcXCM0WEeuigeiFVall-kou0ykJybOpks5sZpV9gaJpZM4O8Pqj .
Thanks! I made some improvements to the UI and project structure. I noticed that the undo functionallity is flawed since the app allows two players to have the same name. When two players have the same name and switched poisitions, the system creates money out of nowhere.
Hi Richard,
I have a suggestion that can fix the bug that you found.
- Would you be okay if I created a UIAlertController to prevent from players from picking the same token twice? This would help me with fixing the bug and in Monopoly, a player is associated to one unique token.
Miguel
Yes, I would be ok with that. What if the user deletes a player and creates a new one with the same token though? We might want to give each user a unique id to get around this.
Great suggestion on creating a unique id for each player. Next commit will be for the UIAlertController.
All necessary changes have been made, go ahead and check it out when you have a chance.
Hi and thank you for your contribution. I will review the changes in a few days and if everything is ok I will eventually merge them and push an update to the AppStore.
Hi Miguel! Sorry for this taking literally a year. I just came back to this project and will review your PR again. I will most likely model the transaction log after your implementation.
Hi Richard, great to hear from you again. Sorry for not getting back to you sooner, I was away for a bit. Looking forward to working with you again and hopefully contributing more to your project.