GeospatialStroke icon indicating copy to clipboard operation
GeospatialStroke copied to clipboard

dodgr automatically removing impassable routes for given wt_profile?

Open MilesMcBain opened this issue 6 years ago • 3 comments

Thanks for this excellent resource. I am currently working through a similar workflow for analysing the effects of relocating a fire station in Queesnland.

In Catchment Zones, Step 8 the following statement is made:

The resultant network has a d_weighted column which preferentially weights the distances for the nominated mode of tranport. Those parts of the network which are unsuitable for vehicular transport have values of .Machine$double.xmax = r .Machine$double.xmax. Because we want to align our random points to the routable component of the network, these need to be removed.

net <- net [which (net$d_weighted < .Machine$double.xmax), ]
nrow (net)
#> [1] 293853

I've found that on a different street network in Queensland, this step had no effect, as weight_streetnet() has dropped edges which were impassable for "motorvehicle". I've verified this by comparing the values of way_id present in the weighted network with the osm_id in the streetnet downloaded using dodgr_streetnet().

Is this step no longer requried? I couldn't find any reference to it in the dodgr NEWS file.

MilesMcBain avatar Aug 13 '19 03:08 MilesMcBain

Thanks Miles, and thanks for the usage and positive feedback. I'll check it out asap. Congrats on your job too - Nick told me about it, sounds great!

mpadge avatar Aug 13 '19 04:08 mpadge

Ah, yeah, you're right @MilesMcBain, that step is no longer necessary, because of this line, which was buried in this commit while my head was full of other ideas. Sorry about that. (Auto-removal of non-routable ways is also implemented for sc format with time-based routing.)

@richardbeare @GNtem2 Is the idea now that we update the site on an ongoing basis? Should I amend accordingly? If Yes and Yes, then I'll do a PR with updated description following the comments of @MilesMcBain. Thanks Miles!

mpadge avatar Aug 13 '19 05:08 mpadge

I think we should aim to keep the web site working with current versions of the packages, so yes, please update and send a PR.

richardbeare avatar Aug 13 '19 11:08 richardbeare