critical eye

[richardbeare]

@mdsumner Final countdown is on. Not sure of your status now. The draft is getting close to submission. We're short on discussion at the moment, but will get some ideas from Thanh. Would value any suggestions on the article as it stands. Latex code in article/geospatial-stroke.tex. Also, please add your affiliations.

[mdsumner]

Thanks! Is there a single rendered version that I can read directly?

[richardbeare]

I'll email the pdf.

[mdsumner]

Wow it's looking really good, I've read all the text and most of the code. I'll have another go through the code. Just a few notes:

• python/Python (does one not always capitalize, I don't actually know ...)
• modelling/modeling (page 3, line 80)
• page 4, line 134 "Geocoding and travel time estimation are two common"
• page 5, line 155 "OSM is also unusual in that it allows access"

I tend to say "longitude/latitude" because that's how we use it in practice, despite OGC 4326 specifics. Perhaps it's worth noting that "in practice longitude is X and latitude is Y, otherwise know as easting and northing in projected form" when those words are introduced. It's not an easy topic to encapsulate quickly, but it's so clearly introduced I wonder if it's worth mentioning upfront? Even experts will commonly mix up the order based on the way we use language compared to our code.

[gboeing]

Perhaps it's worth noting that "in practice longitude is X and latitude is Y, otherwise know as easting and northing in projected form" when those words are introduced.

I think this is worth briefly stating explicitly as to reduce confusion if this is meant for a broad audience.

modelling/modeling (page 3, line 80)

Apologies, it was probably me accidentally introducing Americanized spellings here and there :)

python/Python (does one not always capitalize, I don't actually know ...)

We should capitalize Python throughout.

[gboeing]

Spelling and capitalization fixes in #33

[richardbeare]

Thanks guys - will add the coordinate stuff.

[richardbeare]

FYI - the web site

[mdsumner]

In Catchment Zones, the sentence "so that coordinate reference system is retained." Could be

"so that sf data frame structure is retained". (or similar)

Because I think that's the point, not the CRS per se? Reversing the args retains the geometry column and CRS, but drops the sf class.

[richardbeare]

@SymbolixAU can you add your preferred affiliation to the top of the latex document (or post it here).

[mdsumner]

Here's mine:

$^{5}$ Australian Antarctic Division, Department of the Environment and Energy, Kingston, Tasmania, Australia\\

thanks!

[SymbolixAU]

@richardbeare

Symbolix Pty Ltd, Melbourne, Victoria, Australia

[njtierney]

@richardbeare

Department of Econometrics and Business Statistics, Monash University, Australia