scryber.core icon indicating copy to clipboard operation
scryber.core copied to clipboard

Allow images urls with trailing query string

Open bashuss opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. Image urls may not always end with .jpg, .png, ... as the urls may contain sizing and cropping information in a query string. This of course only applies for images sourced on the web - is that supported? I can not get it to work (testing with current dev branch with localhost urls).

Describe the solution you'd like Adjust the RegEx of the imageFactories, so a query string may follow. Allow web images to be included in render.

Describe alternatives you've considered An easy way for revisiting all images-urls after document parsing for adjustments to the paths.

Additional context Add any other context or screenshots about the feature request here.

bashuss avatar Feb 25 '24 13:02 bashuss

Hi Bernd, thank you for this. I think we had the same issue at a similar time as I have checked-in a change onto the sig-improvements branch. However I will migrate this to the main branch tomorrow and release as definitely a defect. :-)

richard-scryber avatar Feb 26 '24 09:02 richard-scryber