python-uds icon indicating copy to clipboard operation
python-uds copied to clipboard

suggest to add support for extended frame (CAN 2.0b)

Open kaizh102 opened this issue 4 years ago • 1 comments

seems current implementation in CanTp doesn't support diagnostic frame with 29-bit identifier. The parameter "extended" in bus.sent() method inside CanTp class is hard coded to "False". Suggest to add support for extended frames.

kaizh102 avatar Apr 14 '20 22:04 kaizh102

line 47 of .\uds\uds_communications\TransportProtocols\Can\CanConnection.py, "extended=False" makes it impossible to support diagnostics over extended CAN ID.

    def transmit(self, data, reqId, extended=True):
        canMsg = can.Message(arbitration_id=reqId, extended_id=extended)
        canMsg.dlc = 8

        canMsg.data = data

        self.__bus.send(canMsg)

kaizh102 avatar Dec 30 '21 20:12 kaizh102