python-uds
python-uds copied to clipboard
suggest to add support for extended frame (CAN 2.0b)
seems current implementation in CanTp doesn't support diagnostic frame with 29-bit identifier. The parameter "extended" in bus.sent() method inside CanTp class is hard coded to "False". Suggest to add support for extended frames.
line 47 of .\uds\uds_communications\TransportProtocols\Can\CanConnection.py, "extended=False" makes it impossible to support diagnostics over extended CAN ID.
def transmit(self, data, reqId, extended=True):
canMsg = can.Message(arbitration_id=reqId, extended_id=extended)
canMsg.dlc = 8
canMsg.data = data
self.__bus.send(canMsg)