codeimage icon indicating copy to clipboard operation
codeimage copied to clipboard

🐞 - Exported image should not have the active background if there is only one tab

Open riccardoperra opened this issue 2 years ago • 3 comments

Which @codeimage/* package(s) are the source of the bug?

codeimage

Please provide a screenshot or a video to a minimal reproduction of the bug

No response

Description

image

Expected export

image

Which browsers have you used?

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

Which operating systems have you used?

  • [ ] macOS
  • [ ] Windows
  • [ ] Linux
  • [ ] iOS
  • [ ] Android

riccardoperra avatar Jun 10 '22 07:06 riccardoperra

Started exploring this issue, anyone working on this one

piyushjohnson avatar Jun 15 '22 08:06 piyushjohnson

Hi @piyushjohnson, I think no. I can assign this issue to you 😄

If you need any information or support, feel free to ask!

Just a small recommandation: currently the export function clone each node and exports everything is present in the DOM. The simplest way to resolve this issue is to remove the active style of the tab if there is only one tab present.

https://github.com/riccardoperra/codeimage/tree/main/apps/codeimage/src/components/Terminal/Tabs

The style of the tab is attached through Vanilla-Extract recipe https://github.com/riccardoperra/codeimage/blob/89593138b5af7f69e946a1b54f682bc2a92b5a32/apps/codeimage/src/components/Terminal/Tabs/Tab/WindowTab.tsx#L55-L60 so probably I would look here too

riccardoperra avatar Jun 15 '22 08:06 riccardoperra

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 14 '22 11:08 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 16 '22 20:11 stale[bot]