ggradar icon indicating copy to clipboard operation
ggradar copied to clipboard

Add arguments to fill polygons and set fill alpha for transparency

Open abidawson opened this issue 5 years ago • 4 comments

Closes #13

abidawson avatar Oct 27 '19 23:10 abidawson

Hi @abidawson, thanks for the PRs. It looks like this one has some conflicts. Can you try to rebase resolve?

ricardo-bion avatar Nov 25 '19 17:11 ricardo-bion

Hi, I found the file was conflicting. Ifound the update of the ggradar.R in https://github.com/ricardo-bion/ggradar/blob/8dae943d53da227922894bf980c829f694f9e7dd/R/ggradar.R. However, the file of ggradar.R did not update in the "Code"/R. I tried to change the code locally and reinstall to Rsutdio, but it didn't work. I sincerely hope that you can update the file in the "Code".Thank you!@abidawson @ricardo-bion @gousiosg @eknud

zh-Bian avatar Jun 24 '20 14:06 zh-Bian

@tonyy0001 Is it worth resolving these conflicts and merging this one?

ricardo-bion avatar Apr 11 '23 16:04 ricardo-bion

@tonyy0001 Is it worth resolving these conflicts and merging this one?

Thank you for your merging! It is an incredible project!

I have included these and all of the past features in my tidyverse style code. However, I have changed some of the variable names based on it and for readability as well as logical coding, so the code can be a little bit different from the original one. And that's the reason why I created another R file instead of making changes to the original one. I sincerely hope the users could adapt to the new function step by step, as it is more logical and easier for developers to contribute to it.

tonyy01 avatar Apr 11 '23 16:04 tonyy01