ng2-imageupload icon indicating copy to clipboard operation
ng2-imageupload copied to clipboard

Published 20 hours ago • verified publisher icon ribizli

***Suggest naming! - Renaming the module for new angular naming convention

Open saiyaff opened this issue 7 years ago • 3 comments

Here's the link explains it. Link

saiyaff avatar Mar 25 '17 18:03 saiyaff

I don't think it's a big thing to keep legacy names, anyway I don't want to confuse the users with this, and pollute npm with a new name (or with the obsolete one).

ribizli avatar Mar 25 '17 19:03 ribizli

I was thinking about the rename. The current naming imageupload doesn't reflect really what this module/directive does: resizing and converting the selected images into a dataUrl. I'd like to use this issue to comment about suggested renamings. In this process we can also rename the ng2 prefix to be just ng or angular.

ribizli avatar Mar 27 '17 19:03 ribizli

"ng" implies for the old angular-1.x version (angularjs) I've seen in another project the prefix "ngx" - and I think that's fine ...

here are some suggestions (without prefix):

  • image-file-selection (because it operates with the input type="file")
  • image-selection
  • image-converter (resize as optional cough)
  • image-to-dataurl (which describes the main intention)

DoKraus avatar Mar 29 '17 09:03 DoKraus