bbbeasy icon indicating copy to clipboard operation
bbbeasy copied to clipboard

Improve session init and timeout handling

Open neddllly opened this issue 1 year ago • 10 comments

Description

Enter a brief description of the bug being fixed.

Changes Made

Describe the changes made to fix the bug

Closes Issue(s)

Related Issue(s)

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (provides speedup with no functional changes)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Automated testing implementation or update
  • [ ] Dependencies updated to a newer version
  • [ ] Documentation update
  • [ ] Experimental feature that requires further discussion

Screenshots and screen captures

neddllly avatar Sep 13 '23 16:09 neddllly

An error appears when running the project (installer)

image

Desktop (please complete the following information):

OS: Windows

Browser: Chrome/Edge/Opera/Firefox

marwa-benhassine avatar Sep 14 '23 09:09 marwa-benhassine

This error appears when trying to login with a user that does not exist or with a user after registration

image

marwa-benhassine avatar Sep 14 '23 10:09 marwa-benhassine

we should be blocked install process if and administrator user is available in the database .

install

marwa-benhassine avatar Sep 14 '23 14:09 marwa-benhassine

After changing the admin name from the roles page, this error appears

Error

Class "Actions\Roles\User" not found

Administrator

marwa-benhassine avatar Sep 14 '23 14:09 marwa-benhassine

Still the same problem as described above https://github.com/riadvice/bbbeasy/pull/915#issuecomment-1719062286

marwa-benhassine avatar Sep 14 '23 15:09 marwa-benhassine

Still the same problem as described above #915 (comment)

there isnt anymore this function-> collectCurrentUser

neddllly avatar Sep 14 '23 16:09 neddllly

I had a discussion with @neddllly and it seems like there more consistency issues that needs to be fixed : https://github.com/riadvice/bbbeasy/issues/916. Testing will happen again on this PR when the necessary code is refactored.

GhaziTriki avatar Sep 14 '23 17:09 GhaziTriki

@marwa-benhassine Merges from PR #918 should fix edit issues. We can confirm with additional testing.

GhaziTriki avatar Sep 18 '23 05:09 GhaziTriki

Okay Sir @GhaziTriki

marwa-benhassine avatar Sep 18 '23 07:09 marwa-benhassine

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
21.2% 21.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Sep 20 '23 07:09 sonarqubecloud[bot]