terraform-aws-imagebuilder-pipeline icon indicating copy to clipboard operation
terraform-aws-imagebuilder-pipeline copied to clipboard

[Feature] Find a better solution for situations where a log_prefix is not provided for the S3 Bucket

Open dgoodellrhy opened this issue 5 years ago • 1 comments

Is your feature request related to a problem? Please describe. If you don't specify a log_prefix for the S3 logging bucket, each time the pipeline runs AWS generates a new prefix based on the pipeline name and SSM Execution hash, and the end result is that your logs go into unpredictably names prefixes that aren't easy to sort by date, and are maybe impossible to identify unless you get an error message from the pipeline explaining where the logs were sent.

Describe the solution you'd like I don't know, maybe just override an empty log_prefix with the pipeline name? Anything is better than the default behavior I think.

Describe alternatives you've considered I mean, we're technically taking away functionality by forcing a prefix, in case there's anyone out there who wants to do things the bad way? We could leave it as is and rely on making logs more easy to access another way (cloudwatch? I don't know)

Additional context you told me to make this issue in slack! so i did.

dgoodellrhy avatar Jul 21 '20 23:07 dgoodellrhy

Would this be better handled in documentation? It isn’t our job to make the implementation not stupid.

cdaniluk avatar Jul 22 '20 02:07 cdaniluk