Rhys Thomas

Results 25 comments of Rhys Thomas

Also - there is an inconsistency in function naming - `calc_mask` and `set_crop`?

As far as I'm aware, everything still seems to works as expected with a masked array. It does incur an overhead (but much smaller by a factor 1000 than the...

A masked array is only returned when a mask is provided. If unset, the normal map data is passed through as before.

Are you plotting the GBs as lines or as pixels? Looks like you might be plotting as lines and I don't think it correctly handles what is happening outside the...

Hi Ty, The 'develop' branch of DefDAP supports the .ang EDAX file format. You can download it here: https://github.com/MechMicroMan/DefDAP/tree/develop. We have changed quite a lot in this version so take...

Yes on develop. Ah ok, maybe we should change the example notebook to use generate instead of find_grains? Sent from Outlook for iOS ________________________________ From: Michael Atkinson ***@***.***> Sent: Wednesday,...

And yes I think it does just generate the grains on first execution. Sent from Outlook for iOS ________________________________ From: Rhys Thomas ***@***.***> Sent: Wednesday, July 10, 2024 5:01:21 PM...

This breaks ifp colour plotting so not a good approach. maybe just changing the labels is fine.

I checked hex and did a quick patch [cb858f4](https://github.com/MechMicroMan/DefDAP/pull/135/commits/cb858f458317dba69a494aa5f5b6e6bbeb07e3aa). I'll check cubic also and get back to you.

@mikesmic I've added a test for `Quat.calc_ipf_colours` based on values that I know are correct. Do you have any suggestions on how to improve? I have also added a patch...