electron-about-window
electron-about-window copied to clipboard
About window on windows seems pretty limited
... or i am messing it up.
I am using about-window 1.13.4 and the about window on linux is as i am expecting it. See screenshot:
The same build on windows shows the following about window:
Any idea why:
- the image is missing on windows
- the version string is wrong?
- almost anything else is missing as well :)
Please share your source code. You probably made a minor mistake, since it's working fine for me on windows.
@Mavahu
The related project is here: https://github.com/yafp/media-dupes The main js file here: https://github.com/yafp/media-dupes/blob/master/main.js
I'm seeing the same issue.
const openAboutWindow = require('about-window').default;
// later on
openAboutWindow({
icon_path: path.join(__dirname, '..', 'icon.png'),
copyright: 'Copyright (c) 2020 Stoplight, Inc',
});
Linux:
Windows:
Hang on, I'm gonna test to see if it's a /
vs \
thing.
Update: nope, that's not it. Not sure what problem is.
Alright, figured it out. It is an error in usage: when declaring the menu item for the About dialog, be sure to not specify role: 'about'
.
It appears in previous versions of Electron, the about
role was undefined in Windows and now it is, or the click
handler overrode the role or something. I guess Linux has never had it defined so that the presence of the role
property there has never caused an issue.
Anyway. Now I get a lovely dialog on Windows.