Romain Hugonnet

Results 246 comments of Romain Hugonnet

And just to re-explain the logic here for the record (as we'll lose the Slack conv eventually), and make the link to GeoUtils (where most of the changes will need...

Yes, I think two levels is perfect. But I would definitely have Matplotlib optional (which is actually quite heavy), given that the focus of our package is not plotting at...

I thought we already discussed that xDEM workflows would only be run with optional dependencies anyway? @adebardo @belletva Because we don't want to impose on all users the dependencies specific...

Yes, fully agree! Looking at it again, most of `dem_coregistration`'s code seem better suited to a CLI-like interface. Some thoughts for adapting the pieces of code: - I think "I/O"...

Yes, the static typing works (if users use an IDE, they'll probably see that their argument is wrong), but the code doesn't fail elegantly if not because we aren't actually...

Thanks @christopheogier for the issue. The DEM is shifted vertically? If yes, the source of the problem is likely that Rasterio that doesn't support 3D reprojection, which is out of...

I think we should use a consistent number of significant figures (3?) to ensure the number of various magnitude that we have always display correctly. Apparently there's two ways of...

Thanks @adebardo, this would be an essential addition indeed! 🙂 My main feeback at this stage: If understand correctly after looking at Pandora's code, we would rely primarily on [psutil](https://github.com/giampaolo/psutil)?...

FYI: Joins this issue: https://github.com/GlacioHack/xdem/issues/635

@marinebcht Yes! We can import directly the underlying function `_translate` here: https://github.com/GlacioHack/geoutils/blob/8554fa410c647a3bf58f53a777439ab4d2cbc3ee/geoutils/raster/geotransformations.py#L232, which doesn't require a `Raster` but only the `transform`. (as no array is needed for a horizontal translation,...