image-match icon indicating copy to clipboard operation
image-match copied to clipboard

Elasticsearch 6 compatibilty

Open CMCDragonkai opened this issue 6 years ago • 5 comments

Does image-match work with elasticsearch 6? It doesn't seem like there was any relevant breaking changes. If so, can we bump up the version constraint in the setup.py?

CMCDragonkai avatar Jul 18 '18 06:07 CMCDragonkai

@fabito Do you recall why you specified the elasticsearch module version as 'elasticsearch>=5.0.0,<6.0.0', [commit]? All the tests pass on 6.2.0; in fact it's the only version with which I've run image-match!

duhaime avatar Jul 23 '18 20:07 duhaime

Any news regarding this issue @duhaime ? I'm also facing some problems because v1.1.2 is still with an older version of elasticsearch.

RicardoBrazao avatar Aug 23 '18 15:08 RicardoBrazao

I use it with elasticsearch 6.3.1 without any issues... I would really like to bumb the version too. Is there any reason not to do this?

markusressel avatar Mar 08 '19 01:03 markusressel

@fabito Do you recall why you specified the elasticsearch module version as 'elasticsearch>=5.0.0,<6.0.0', [commit]? All the tests pass on 6.2.0; in fact it's the only version with which I've run image-match!

AFAIR no specific reason. If the tests are passing I don't see why we shouldn't upgrade.

fabito avatar Mar 08 '19 01:03 fabito

I did not run tests (haven't even cloned this repo so far), but I use it in my own little library without any issues. Currently I just set the elasticsearch version in my setup.py to enforce the newer version.

markusressel avatar Mar 08 '19 02:03 markusressel