image-match icon indicating copy to clipboard operation
image-match copied to clipboard

skimage `imread` as_grey vs as_gray

Open gwd666 opened this issue 4 years ago • 4 comments

Just to let you know, make you aware that based on https://stackoverflow.com/questions/58993530/typeerror-self-open-got-an-unexpected-keyword-argument-as-grey-python I ran into that same issue ... it may require, at least this fixed it for me, a small tweak in goldberg.py to line 239 and 246 from return imread(image_or_path, as_grey=True) to return imread(image_or_path, as_gray=True)

Otherwise nice piece of work!

gwd666 avatar May 13 '20 15:05 gwd666

you need reinstall the scikit-image

 pip install scikit-image==0.14.0

JavisPeng avatar Jun 18 '20 01:06 JavisPeng

you need reinstall the scikit-image

 pip install scikit-image==0.14.0

Since [I think] they changed the parameter naming in scikit-image 0.15 I get your advice.; I am on scikit-image 0.17.1 - with the small above tweak to the imread calls it is no big deal; would there be any other reason for downgrading by ~6 versions, issues with 0.17 and your code I am not aware of? Otherwise it could just benefit others if we leave this ticket open, in case someone else runs into the same issue?

gwd666 avatar Jun 18 '20 15:06 gwd666

so we all just stick to old versions now?

darkfader avatar Dec 21 '20 23:12 darkfader

I haven't see any issues with a manually patched version either.

jose1711 avatar Jun 19 '21 19:06 jose1711