Ryan Henderson

Results 45 comments of Ryan Henderson

i need a vacation :rofl:

That is strange. I'm on vacation until Apr 5, but please share any other information or if you figure out what the problem is. Otherwise, I will look into it...

Hey @SthPhoenix, does that mean you don't think it's a color space issue (i.e. is completely explained by the rotation?)

any suggestions, then? should we switch to cv2?

Well I think you know what I'm going to ask for next, @SthPhoenix =)

I get the same error: ```python In [3]: im.generate_signature('https://cloud.githubusercontent.com/assets/17834919/25771654/4aa9732c-3260-11e7-8370-8fcc62418 ...: 677.JPG') --------------------------------------------------------------------------- IndexError Traceback (most recent call last) in () ----> 1 im.generate_signature('https://cloud.githubusercontent.com/assets/17834919/25771654/4aa9732c-3260-11e7-8370-8fcc62418 677.JPG') /home/ryan/image-match/image_match/goldberg.py in generate_signature(self, path_or_image, bytestream) 164...

@SthPhoenix maybe this is not a real jpeg? Usually the `shape` property is rows x columns x color depth ```python In [1]: from skimage.io import imread In [2]: r =...

Looks like RGB (dimensions l x w x 3 0-255) vs greyscale (l x w 0.0-1.0). They're all greyscaled by image-match anyway. > BTW, are there any specific reasons to...

Hello again @Lvctao, The image-match algorithm is theoretically capable of handling heavy cropping, but this hasn't been implemented yet. Therefore, I'm not surprised your images aren't matching. If you are...

Hi @miqwit thanks for the PR! I'll be away at a conference this week, but I'll try to look over this ASAP.