retrying icon indicating copy to clipboard operation
retrying copied to clipboard

Friendly fork ?

Open bersace opened this issue 8 years ago • 10 comments

TL;DR Go use https://github.com/jd/tenacity ! :)

Hi,

retrying is a nice piece of code, thanks to @rholder and contributors !

Sadly there is no activity since june 2016. Several contributors suggest to create a friendly fork to keep retrying alive. I'm one of them.

What do you think of this ?

cc @RyPeck @charlescbeebe @reversefold @harlowja @bodenr @robin81 @jpic @doubleloop @davidyen1124 @underrun

bersace avatar Nov 22 '16 09:11 bersace

@bersace have a look at: https://github.com/jd/tenacity

bodenr avatar Nov 22 '16 11:11 bodenr

@bodenr @jd love the name.

RyPeck avatar Nov 24 '16 00:11 RyPeck

For the record, yeah, I tried to work with @rholder for a few months but I guess he's very busy. Since we did not manage to go anywhere with retrying for a long time, so I ended up forking it.

jd avatar Nov 24 '16 09:11 jd

Can we keep a fork with the original name please? I really don't want to go back and change a bunch of code. Name change are a big deal.

Also, i dont mind a fork, but it's much more polite if you actually forked something on GitHub to actually fork it on GitHub so that people can see the lineage and that it is a fork of an original repo. This looks - at best

  • either inept or discourteous.

I'm seriously not trying to ruffle feathers here - i just think these things should be considered and we should treat people with respect even when they get busy or whatever.

This is, after all, a thread about a friendly fork. Let's be friendly.

underrun avatar Nov 24 '16 16:11 underrun

I switched to tenacity. It has been nicely cleaned.

@underrun you may provide a open a PR with compatibility module in https://github.com/jd/tenacity ?

bersace avatar Nov 24 '16 16:11 bersace

While I understand your concern @underrun, I imagine the lack of context and information makes your comment a little bit offensive. :)

So for the record, the API is not compatible, so there's no point keeping any name. And @rholder never replied to any of my request to help maintaining this library and I've no PyPI access to upload it.

jd avatar Nov 24 '16 17:11 jd

That's the sad story of many nice Python libraries that become abandonware because they had only one person behind them.

For this reason I published all Python libraries under pycontribs github team where I assured there are others that can continue improving them even without me.

Some people do think that forks are good but my view is a little bit different: they are usually a sign of something not working in the forked project. Forked projects to confuse people, not adding much to the overall user/consumer/developer experience.

It is much better when there is no need to fork, everyone working for the same goal: of having one library that really works (as opposed to having 10 blends which all partially work).

@rholder If you read this and like the idea of sharing maintenance with few other skilled Python developers, feel free to ping me. For the moment I am going to have a look at https://github.com/jd/tenacity as it seems to be better bet (actively maintained) ;)

ssbarnea avatar Jan 11 '17 20:01 ssbarnea

@ssbarnea Another, more popular Python join effort is https://jazzband.co/

xmedeko avatar Jan 17 '17 19:01 xmedeko

@jd or contributor at tenacity, will there be list abandoned/resolved issue and merged/skipped pr from this library?

because after this issue, there are #66, and #69

rachmadaniHaryono avatar Jun 22 '17 14:06 rachmadaniHaryono

@rholder Hi, can you state the project is unmaintained either by archiving it or adding a tag in the description ? What do you think of it ?

bersace avatar Nov 02 '18 08:11 bersace