gradle-one-jar icon indicating copy to clipboard operation
gradle-one-jar copied to clipboard

Stop using deprecated Manifest.writeTo(Writer) and use Manifest.writeTo(Object) instead

Open olisikh opened this issue 7 years ago • 14 comments

In Gradle 4.0 Manifest.writeTo(Writer) will be removed, to make it compatible, Manifest.writeTo(Object) needs to be used

olisikh avatar Jun 30 '17 08:06 olisikh

Please merge this we are blocked with version 4

sebastienvermeille avatar Jul 06 '17 12:07 sebastienvermeille

Looks like the plugin owner doesn't maintain the project any longer :(

olisikh avatar Jul 06 '17 12:07 olisikh

@alisiikh I contacted him on twitter if we don't get any response should we do a fork of it and maintain it ?

sebastienvermeille avatar Jul 06 '17 12:07 sebastienvermeille

+1 Please merge this.

martin-linha avatar Jul 19 '17 13:07 martin-linha

I wrote him on twitter no reaction. Maybe he is on holidays

sebastienvermeille avatar Jul 19 '17 13:07 sebastienvermeille

Please release it. Thanks!

martin-linha avatar Aug 07 '17 14:08 martin-linha

We have a fork here for those interested.

LeviticusMB avatar Aug 12 '17 09:08 LeviticusMB

Forking is a good first step, but are you publishing it as a plugin in the gradle plugin repository? A link to that would be more helpful (I didn't find it with their search).

nsoft avatar Aug 12 '17 16:08 nsoft

Yes I will publish. Need a couple of days though.

LeviticusMB avatar Aug 12 '17 20:08 LeviticusMB

See

  • https://plugins.gradle.org/plugin/com.github.onslip.gradle-one-jar
  • http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22gradle-one-jar%22

LeviticusMB avatar Aug 13 '17 11:08 LeviticusMB

nice that you published it, but I see you aren't enabling issue reporting on your github repo :( I suppose that's you being upfront about not wanting to maintain it, but the floundering continues the next time something breaks... sigh

nsoft avatar Apr 15 '18 19:04 nsoft

Well ... why not. Issue reporting has been enabled.

LeviticusMB avatar Apr 17 '18 06:04 LeviticusMB

Cool, that's encouraging :) thanks

nsoft avatar Apr 17 '18 18:04 nsoft

fixes issue https://github.com/rholder/gradle-one-jar/issues/34, too

nros avatar Jun 30 '18 20:06 nros