rhinstaller
Add kickstart tests for the bootc based source
Bootc is a new way of deploying images added to the Anaconda. Those tests cover basic testing schema validating the installed system image.
@jstodola Okay, this has been updated. I think once everything is merged we need to create at least one more test that checks that the system is fine post-reboot.
The latest kickstart file I was using for manual test of the main bootc PR:
bootloader --timeout=1
zerombr
clearpart --all --initlabel
autopart --nohome --noswap
lang en_US.UTF-8
keyboard us
timezone America/New_York --utc
rootpw testcase
bootc --source-imgref=registry:quay.io/fedora/fedora-bootc:rawhide --stateroot=default
/test-os-variants
Thank you for the workaround. I'd prefer to limit it just to the bootc-basic (and other potential bootc-) tests. Maybe by adding fragments/shared/validation/success_on_first_boot_bootc.ks. So that we don't break other tests accidentally and are more free to tune it for bootc? I'd prefer to be safer at this level of maturity of the bootc stuff. The list of tests using the fragment:
[rvykydal@rvykydal-thinkpadp16vgen1 ~/work/review/bootc_6298.2/kickstart-tests (elkoniu-add-bootc-tests-DBG-big)]$ grep success_on_first_boot *.ks.in bootc-basic.ks.in:%ksappend validation/success_on_first_boot.ks dns-global-exclusive-tls-2.ks.in:%ksappend validation/success_on_first_boot.ks dns-global-exclusive-tls.ks.in:%ksappend validation/success_on_first_boot.ks dns-global-exclusive-tls-ksnet.ks.in:%ksappend validation/success_on_first_boot.ks raid-ddf.ks.in:%ksappend validation/success_on_first_boot.ks reboot-initial-setup-gui.ks.in:%ksappend validation/success_on_first_boot.ks reboot-initial-setup-tui.ks.in:%ksappend validation/success_on_first_boot.ks reboot.ks.in:%ksappend validation/success_on_first_boot.ks reboot-uefi.ks.in:%ksappend validation/success_on_first_boot.ks rootpw-allow-ssh.ks.in:%ksappend validation/success_on_first_boot.ks rpm-ostree-container-bootc.ks.in:%ksappend validation/success_on_first_boot.ks rpm-ostree-container-luks.ks.in:%ksappend validation/success_on_first_boot.ks rpm-ostree-container-uefi.ks.in:%ksappend validation/success_on_first_boot.ks selinux-contexts.ks.in:%ksappend validation/success_on_first_boot.ks storage-multipath-autopart.ks.in:%ksappend validation/success_on_first_boot.ks
I tried to make it such that it will not impact other tests. I think all tests are also passing: https://github.com/rhinstaller/kickstart-tests/actions/runs/19168396471
I dont mind splitting, but it will create quite a lot of code duplication. Up to you, you 're the guard of this repo @rvykydal
I cared the most about the rpm-ostree-container tests now not (although by unintended side-effect) testing the /var mounting by the service. OTOH the impacted tests are detected by /test-os-variants so any updates for the bootc code would be tested by CI.
We need to disable the tests on variants where the feature is not supported (eg skip-on-rhel9, .... in TESTTYPE, see other tests) to make /test-os-variants green for the unsupported variants.
/test-os-variants https://github.com/rhinstaller/kickstart-tests/actions/runs/19169390922
Re-checking the failures:
/test-os-variants dns-global-exclusive-tls-ksnet rpm-ostree-container-uefi rpm-ostree-container-boot
/test-os-variants dns-global-exclusive-tls-ksnet rpm-ostree-container-uefi rpm-ostree-container-boot
/test-os-variants dns-global-exclusive-tls-ksnet rpm-ostree-container-uefi rpm-ostree-container-boot
/test-os-variants dns-global-exclusive-tls-ksnet rpm-ostree-container-uefi rpm-ostree-container-boot
[PASS/WAIVED] Succeeded except for dns-global-exclusive-tls-ksnet which fails also on daily tests.