Apply configuration in installer cannot be saved persistently

[zhb4]

Thank you for your contribution!

Please check that your PR follows these rules:

• [ ] Code conventions. tl;dr: Follow PEP8, wrap at 100 chars, and provide docstrings.

• [ ] Commit message conventions. tl;dr: Heading, empty line, longer explanations, all wrapped manually. If in doubt, write a longer commit message with more details.

• [ ] Tests pass and cover your changes. You can run tests locally manually, or have them run as part of the PR. A team member will have to enable tests manually after inspecting the PR. If you don't know how, ask us for help!

• [ ] Release notes and docs if the PR adds something major or changes existing behavior. If you don't know how, ask us for help!

• [ ] RHEL rules: If your PR is for a rhel-* branch, pay special attention to commit messages. Make sure all commit messages include a line linking the commit to a bug, such as Resolves: RHEL-123456. For more information, see the complete rules. If you don't know how, ask us for help!

Don't forget - if you don't know how, ask us for help!

And now that you read this all, you can delete it and type your own description of your changes :-)

[gemini-code-assist[bot]]

Summary of Changes

Hello @zhb4, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where network configuration settings applied within the installer were not being saved persistently. It introduces a robust mechanism to manage the 'apply configuration' state by leveraging NetworkManager's connection zone property. This ensures that user-defined network persistence choices are correctly maintained and applied across system reboots or subsequent installer sessions, improving the reliability of network setup.

Highlights

• Configuration Persistence: Introduced a new apply_configuration flag within WiredTUIConfigurationData to track whether network settings should be saved persistently.
• NetworkManager Zone Mapping: Implemented logic to map the apply_configuration flag to the NetworkManager connection's zone property. A zone of 'anaconda-apply' now signifies that the configuration should be applied persistently.
• Data Flow Integration: Ensured that the apply_configuration state is correctly read from existing NetworkManager connections when initializing WiredTUIConfigurationData and written back to connections when updates are applied, resolving the persistence issue.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[github-actions[bot]]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/anaconda-pr-6756@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/efi-anaconda-pr-6756@rhinstaller/anaconda-webui

[github-actions[bot]]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/anaconda-pr-6756@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/efi-anaconda-pr-6756@rhinstaller/anaconda-webui

[zhb4]

You need to:

* squash the commits

* remove redundant white spaces

(both the above were part of my previous review #6756 (review))

Explain in the commit message what are you trying to achieve and link the bug report if there is any.

I have deleted the redundant Spaces The patch I submitted is only to fix the issue that Apply configuration in installer cannot be persisted and saved. All the code I submitted has been verified and there is no problem

[github-actions[bot]]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/anaconda-pr-6756@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/efi-anaconda-pr-6756@rhinstaller/anaconda-webui

[zhb4]

You need to:

* squash the commits

* remove redundant white spaces

(both the above were part of my previous review #6756 (review))

Explain in the commit message what are you trying to achieve and link the bug report if there is any.

[zhb4]

You need to:

* squash the commits

* remove redundant white spaces

(both the above were part of my previous review #6756 (review))

Explain in the commit message what are you trying to achieve and link the bug report if there is any.

All the submitted patches have undergone strict testing. I think this issue is quite understandable

[github-actions[bot]]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/anaconda-pr-6756@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/efi-anaconda-pr-6756@rhinstaller/anaconda-webui

[github-actions[bot]]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/anaconda-pr-6756@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6756 fedora-rawhide-boot/efi-anaconda-pr-6756@rhinstaller/anaconda-webui