anaconda icon indicating copy to clipboard operation
anaconda copied to clipboard

Add apply hostname options in Host Name dialog

Open DustMerlin opened this issue 1 month ago • 10 comments

Add apply hostname options in Host Name dialog

DustMerlin avatar Nov 03 '25 09:11 DustMerlin

Summary of Changes

Hello @DustMerlin, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to the Host Name dialog in the pyanaconda TUI. It adds an 'Apply Host Name' option, which, when selected, immediately applies the configured hostname. This provides a more direct and user-friendly way to set the hostname during installation or configuration.

Highlights

  • New 'Apply Host Name' Option: Adds a new option in the Host Name dialog to directly apply the set hostname.
  • Callback Implementation: Implements the _apply_hostname_callback function to set the current hostname using self._network_module.SetCurrentHostname(self.hostname).
  • UI Integration: Integrates the new 'Apply host name' option into the TUI, providing a direct way to apply the hostname.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 03 '25 09:11 gemini-code-assist[bot]

@jkonecny12 Hello.In this pr#6103 we find need to add a apply option in Host Name dialog.So I add it.Could you please review it?Please give me some advice or merge this pr.Thank you!

DustMerlin avatar Nov 03 '25 09:11 DustMerlin

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/anaconda-pr-6732@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/efi-anaconda-pr-6732@rhinstaller/anaconda-webui

github-actions[bot] avatar Nov 03 '25 09:11 github-actions[bot]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-43-boot/anaconda-pr-6732@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-43-boot/efi-anaconda-pr-6732@rhinstaller/anaconda-webui

github-actions[bot] avatar Nov 03 '25 09:11 github-actions[bot]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/anaconda-pr-6732@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/efi-anaconda-pr-6732@rhinstaller/anaconda-webui

github-actions[bot] avatar Nov 10 '25 09:11 github-actions[bot]

Squashed and rebased the PR

KKoukiou avatar Nov 21 '25 06:11 KKoukiou

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/anaconda-pr-6732@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/efi-anaconda-pr-6732@rhinstaller/anaconda-webui

github-actions[bot] avatar Nov 21 '25 06:11 github-actions[bot]

Only members of the Anaconda team can trigger the Web UI tests for this PR. Since you do not have permission, please ask an Anaconda team member to run the following commands:

bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/anaconda-pr-6732@rhinstaller/anaconda-webui
bots/tests-trigger --force --repo rhinstaller/anaconda 6732 fedora-rawhide-boot/efi-anaconda-pr-6732@rhinstaller/anaconda-webui

github-actions[bot] avatar Nov 26 '25 07:11 github-actions[bot]

@KKoukiou There is a problem with this AI review. I have reverted to my original revision. I test successfully. Could you please review and test it again?

DustMerlin avatar Nov 26 '25 07:11 DustMerlin

/kickstart-tests --testtype smoke

KKoukiou avatar Dec 03 '25 08:12 KKoukiou