anaconda icon indicating copy to clipboard operation
anaconda copied to clipboard
verified publisher icon rhinstaller

Get the pre-release flag from /etc/os-release

Open elkoniu opened this issue 11 months ago • 4 comments

Anaconda IsFinal property use to be processed out of ANACONDA_ISFINAL environmental variable. This commit changes this behaviour to use RELEASE_TYPE variable out of /etc/os-release instead.

Resolves: INSTALLER-4068

elkoniu avatar Jan 31 '25 16:01 elkoniu

Also @bcl, isn't the ANACONDA_ISFINAL environment variable used somewhere Lorax / Image Builder?

jkonecny12 avatar Feb 03 '25 09:02 jkonecny12

Also @bcl, isn't the ANACONDA_ISFINAL environment variable used somewhere Lorax / Image Builder?

In lorax the --isfinal cmdline switch is used, and it sets IsFinal in the .buildstamp file. It doesn't check the environmental variable or set it. Neither does livemedia-creator.

osbuild-composer operates the same way, setting IsFinal in .buildstamp and has no references to the variable.

bcl avatar Feb 03 '25 17:02 bcl

Converting this to draft because it has failing unit tests. Please check @elkoniu and when ready undraft the PR.

KKoukiou avatar Mar 06 '25 11:03 KKoukiou

@KKoukiou I have applied suggested changes

elkoniu avatar Mar 20 '25 11:03 elkoniu

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jul 08 '25 03:07 github-actions[bot]

I am considering https://github.com/rhinstaller/anaconda/pull/6525 as alternative to this one.

KKoukiou avatar Jul 22 '25 08:07 KKoukiou

As discussed with @KKoukiou I am dropping this PR as it will be obsolete due to more complex refactoring.

elkoniu avatar Jul 23 '25 10:07 elkoniu