anaconda icon indicating copy to clipboard operation
anaconda copied to clipboard

infra: Add rpmlint test to upstram CI

Open elkoniu opened this issue 1 year ago • 6 comments

rpmlint is used in Fedora dist git in the release process. Having it included in the upstream CI will allow us early detection of the potential linter issues in spec / rpms.

  • [ ] Blocked on fixing the remaining RPM lint issues

elkoniu avatar Oct 10 '24 11:10 elkoniu

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am

github-actions[bot] avatar Oct 10 '24 11:10 github-actions[bot]

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am

github-actions[bot] avatar Oct 13 '24 16:10 github-actions[bot]

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am

github-actions[bot] avatar Oct 13 '24 16:10 github-actions[bot]

@KKoukiou I have update this PR so when rpmlint.toml file will be presented - it will be used by linter. According to documentation this configuration will be merged with default config, which in our case will mean silencing some errors we want to be skipped.

elkoniu avatar Oct 13 '24 16:10 elkoniu

I really like this idea.

jkonecny12 avatar Oct 22 '24 12:10 jkonecny12

This will not fail after PRs introducing config file will be merged.

elkoniu avatar Oct 22 '24 12:10 elkoniu

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am

github-actions[bot] avatar Oct 22 '24 23:10 github-actions[bot]

/kickstart-test --testtype smoke

elkoniu avatar Oct 22 '24 23:10 elkoniu

I wonder, do we need to install Anaconda packages? You are already giving RPMs and spec to the linter. Isn't that enough?

jkonecny12 avatar Oct 23 '24 07:10 jkonecny12

I wonder, do we need to install Anaconda packages? You are already giving RPMs and spec to the linter. Isn't that enough?

I think it is happening because I have appended existing rpm-test - which purpose is I guess to test if produced RPMs can be installed. Katerina proposed to put rpmlint test here instead of creating separated make target.

elkoniu avatar Oct 23 '24 10:10 elkoniu

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am

github-actions[bot] avatar Oct 25 '24 16:10 github-actions[bot]

/kickstart-tests --waive infra only

KKoukiou avatar Oct 25 '24 16:10 KKoukiou