anaconda icon indicating copy to clipboard operation
anaconda copied to clipboard

F40: Lower permissions for kickstart logs in /tmp

Open jkonecny12 opened this issue 1 year ago • 7 comments

These logs could potentially contain sensitive data so let's set these logs as accessible by root only.

This is extension to https://github.com/rhinstaller/anaconda/pull/5466 .

jkonecny12 avatar Feb 16 '24 15:02 jkonecny12

/kickstart-test --testtype smoke

jkonecny12 avatar Feb 16 '24 15:02 jkonecny12

/kickstart-test --testtype smoke

jkonecny12 avatar Feb 20 '24 16:02 jkonecny12

/kickstart-test --testtype smoke

jkonecny12 avatar Feb 26 '24 11:02 jkonecny12

/kickstart-test --testtype smoke

rvykydal avatar Feb 28 '24 12:02 rvykydal

The reason for failing kickstart tests:

[Wed, 28 Feb 2024 12:53:17 virt-install 604] ERROR (cli:257).
--os-variant/--osinfo OS name is required, but no value was
set or detected.

This is now a fatal error. Specifying an OS name is required
for modern, performant, and secure virtual machine defaults.

If you expected virt-install to detect an OS name from the
install media, you can set a fallback OS name with:

  --osinfo detect=on,name=OSNAME
  
You can see a full list of possible OS name values with:

   virt-install --osinfo list

If your Linux distro is not listed, try one of generic values
such as: linux2022, linux2020, linux2018, linux2016

If you just need to get the old behavior back, you can use:

  --osinfo detect=on,require=off

Or export VIRTINSTALL_OSINFO_DISABLE_REQUIRE=1

[Wed, 28 Feb 2024 12:53:17 virt-install 746] DEBUG (cli:256)   File "/usr/bin/virt-install", line 8, in <module>
    virtinstall.runcli()
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1233, in runcli
    sys.exit(main())
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1220, in main
    guest, installer = build_guest_instance(conn, options)
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 654, in build_guest_instance
    installer_detect_distro(guest, installer, osdata)
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 614, in installer_detect_distro
    fail(fail_msg)
  File "/usr/share/virt-manager/virtinst/cli.py", line 256, in fail
    log.debug("".join(traceback.format_stack()))

(kstest.virt-install.log)

rvykydal avatar Feb 28 '24 13:02 rvykydal

/kickstart-test --testtype smoke

rvykydal avatar Feb 28 '24 13:02 rvykydal

/kickstart-test --testtype smoke

jkonecny12 avatar Feb 29 '24 13:02 jkonecny12