Snap-Scraper icon indicating copy to clipboard operation
Snap-Scraper copied to clipboard

i have never programmed in swift but- suggestion for you

Open TotallyNotAHaxxer opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. its just a simple fix

now as the title states i have NEVER not once tried swift however i have had on hand experience WITH ALOT of programming languages, both compiled, interpreted, low and high level languages and i can tell you any form of a constant print statement is not- resource efficient | | so maybe you can have swift read all the basic output into a txt file, an example would be

        writeMessage("SNAP SCRAPER")
        writeMessage("Version 0.5b")
        writeMessage("Last updated 2021:11:05")

converted into a text file with

SNAP SCRAPER 
Version 0.5b
Last updated 2021:11:05
banner>
other text that does not need a print statement

im sure even from personal experience it is alot easier than constantly writing writeMessage and alot more as said above resource efficiant

TotallyNotAHaxxer avatar Nov 23 '21 03:11 TotallyNotAHaxxer

Definitely sounds like a workable improvement. The code is not focused on efficiency at present, likely why the MIT licence is such a good use. I was focused on pushing a tool for the community to use. Efficiency improvements like this are definitely something that should be considered before scaling up. Feel free to create a pull request if you want to work on this?

rhematt avatar Nov 25 '21 02:11 rhematt

i wish i could work on this honestly, i do not have any swift knowlege, emulators, or specified ideas but maybe i will find someone who could, but yeah i understand the community use best of luck to you in the future however! :D

TotallyNotAHaxxer avatar Nov 25 '21 03:11 TotallyNotAHaxxer

Definitely sounds like a workable improvement. The code is not focused on efficiency at present, likely why the MIT licence is such a good use. I was focused on pushing a tool for the community to use. Efficiency improvements like this are definitely something that should be considered before scaling up. Feel free to create a pull request if you want to work on this?

Hey there I came across this issue and looked over your code and was just wondering, if you use multi-line break in Swift you don't have to call the writeMessage function multiple times to create the same effect. I saw ArkAngeL43's suggestion to make a text file and that's good. But if you wanted to keep it in the file I tried a different way. So I decided to test it out in a playground with the Snap-Scraper logo and change it:

Before:

- func logo(){
      writeMessage("--------------------------------------------------------------------------------")
      writeMessage("SNAP SCRAPER--------------------------------------------------------------------")
      writeMessage("Version 0.5b------------------@@@&@@@@@@@@@@@&&---------------------------------")
      writeMessage("Last updated 2021:11:05-----&@@(          ,%%%%%%%%%%%--------------------------")
      writeMessage("--------------------------@@.          .%%(........../%%&-----------------------")
      writeMessage("-----------------------@&@.           *%#............../%%----------------------")
      writeMessage("----------------------@@%        OO   %#................(%&---------------------")
      writeMessage("---------------------@&@.       OOOO  ##................(%&---------------------")
      writeMessage("---------------------@&@        OOOO  *%#.............,(%%----------------------")
      writeMessage("---------------------@&@         OO     %%#(.........(%%------------------------")
      writeMessage("---------------------@&@.                 ,#%%%%%%%%#*.%&-----------------------")
      writeMessage("----------------&@@&@@&@,                              &&&----------------------")
      writeMessage("-------------@&@,  .,**.                                ,*,.   -----------------")
      writeMessage("---------------@&@@&*                                     ,#@@------------------")
      writeMessage("--------------------@&@(                               .@&@@@@@-----------------")
      writeMessage("----------------------@(                               ,@@@@@-------------------")
      writeMessage("-------------------@&@*                                 .@@---------------------")
      writeMessage("-------------------@%                                     *@&-------------------")
      writeMessage("----------------@@(                                         ,@@-----------------")
      writeMessage("----------@%&@@/                                               ,&@@@@-----------")
      writeMessage("--------@@.                                                          %@---------")
      writeMessage("----------@@@@@@%/                                           ,#&@@@@@-----------")
      writeMessage("-----------------@#                                         ,@------------------")
      writeMessage("-----------------@&&&@@@@@@@@%,                  (@@&@@@@@@&&@------------------")
      writeMessage("-------------------------------@@#     RM    *&@&@@-----------------------------")
      writeMessage("--------------------------------------------------------------------------------")
  }

//After 

+ func logo(){
  writeMessage("""
     --------------------------------------------------------------------------------
     SNAP SCRAPER--------------------------------------------------------------------
     Version 0.5b------------------@@@&@@@@@@@@@@@&&---------------------------------
     "Last updated 2021:11:05-----&@@(          ,%%%%%%%%%%%--------------------------
     --------------------------@@.          .%%(........../%%&-----------------------
     -----------------------@&@.           *%#............../%%----------------------
     ----------------------@@%        OO   %#................(%&---------------------
     ---------------------@&@.       OOOO  ##................(%&---------------------
     ---------------------@&@        OOOO  *%#.............,(%%----------------------
     ---------------------@&@         OO     %%#(.........(%%------------------------
     ---------------------@&@.                 ,#%%%%%%%%#*.%&-----------------------
     ----------------&@@&@@&@,                              &&&----------------------
     -------------@&@,  .,**.                                ,*,.   -----------------
     ---------------@&@@&*                                     ,#@@------------------
     --------------------@&@(                               .@&@@@@@-----------------
     ----------------------@(                               ,@@@@@-------------------
     -------------------@&@*                                 .@@---------------------
     -------------------@%                                     *@&-------------------
     ----------------@@(                                         ,@@-----------------
     ----------@%&@@/                                               ,&@@@@-----------
     --------@@.                                                          %@---------
     ----------@@@@@@%/                                           ,#&@@@@@-----------
     -----------------@#                                         ,@------------------
     -----------------@&&&@@@@@@@@%,                  (@@&@@@@@@&&@------------------
     -------------------------------@@#     RM    *&@&@@-----------------------------
     --------------------------------------------------------------------------------
 """)
 }

AE542 avatar Feb 02 '22 13:02 AE542

thats a good suggestion too

TotallyNotAHaxxer avatar Feb 02 '22 22:02 TotallyNotAHaxxer

Implemented AE542 changes.

rhematt avatar Dec 12 '22 00:12 rhematt