klatt icon indicating copy to clipboard operation
klatt copied to clipboard

Invalid enum values for -v (glsource, voicing source)

Open chdh opened this issue 6 years ago • 0 comments

The documentation states:

1 = impulse train. 2 = natural simulation. 3 = natural samples

The old source code was:

#define IMPULSIVE        1
#define NATURAL          2
#define SAMPLED          3

The new source code assigns enum values starting with 0:

typedef enum
{
        IMPULSIVE,
        NATURAL,
        SAMPLED,
} klatt_voicing_source_t;

A fix could be either to specify a start value of 1 for the enum:

typedef enum
{
        IMPULSIVE = 1,
        ...

or to subtract 1 from the argument passed on the command line:

            case 'v':
                    globals->glsource = (flag) atoi(optarg) - 1;
                    break;

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

chdh avatar Mar 15 '19 03:03 chdh