piper icon indicating copy to clipboard operation
piper copied to clipboard

Provide option to save audio to file

Open justjam2013 opened this issue 1 year ago • 4 comments

Update http_server.py with the option of saving the generated speech to file, rather than streaming it back.

By adding a file argument to both the POST and GET requests, the synthesized audio can be stored to the requested filename. Maybe a startup audio_path argument can passed to http_server.py to provide a default location for the audio files, to both control location and not force the file argument to include path information.

Using the changes described above, I have modified http_server.py locally to process incoming requests and store the audio files in a common folder. Once they are available, another process picks up and plays back the audio files.

justjam2013 avatar Nov 09 '24 00:11 justjam2013

Using the changes described above, I have modified http_server.py

Please fork the repository, and file a pull request that mentions this issue (For example, have the commit message read "Completed #639")

thelabcat avatar Nov 21 '24 02:11 thelabcat

Please fork the repository, and file a pull request that mentions this issue (For example, have the commit message read "Completed https://github.com/rhasspy/piper/issues/639")

With 34 open pull requests going back over a year, what is the criteria for a PR being merged versus it remaining open in perpetuity?

justjam2013 avatar May 21 '25 11:05 justjam2013

Probably less than just saying you modified the file and would like the change implemented, but that said there is a significant rewrite going on at the moment.

thelabcat avatar May 22 '25 04:05 thelabcat

Probably less than just saying you modified the file and would like the change implemented

For sure, and I don't mind opening a PR with my changes. However my question was based on noticing that there are a number of what appear to be zombie PRs, going back over a year, which are not accepted, rejected, or commented on. Therefore I asked if there was any particular criteria that would affect a PR's fate one way or the other.

... that said there is a significant rewrite going on at the moment.

This is exciting, thanks for that update. I will keep checking in on this project. It then makes sense to wait until the rewrite is complete and at that point determine if a PR is required.

justjam2013 avatar May 22 '25 12:05 justjam2013