espeak_TextToPhonemesWithTerminator not upstream

[cryptomilk]

trafficstars

Hi,

I'm trying to package piper-tts for openSUSE right now.

• Is there a reason that espeak_TextToPhonemesWithTerminator() has not been submitted upstream to espeak-ng?
• I've changed the CMakeLists.txt so I can build with system libraries, would you accept a patch for this?

https://build.opensuse.org/package/show/home:gladiac/piper-phonemize https://build.opensuse.org/package/show/home:gladiac/piper-tts

[cryptomilk]

The strange thing is that the prototype of TranslateClauseWithTerminator() made it upstream: https://github.com/espeak-ng/espeak-ng/pull/1811

[synesthesiam]

That's very odd that they merged the function prototype with no definition! I didn't submit it upstream for two reasons:

1. I didn't add any tests, and wasn't sure it was even useful outside of Piper
2. I plan on replacing espeak-ng with something else due to licensing concerns (I prefer MIT/public domain over GPL)

[cryptomilk]

I would still try to submit it. I think they would accept it and it would be easier to build piper-tts in distributions. I would love to bring piper-tts to openSUSE and Fedora.

[cryptomilk]

I've open a pull request for cmake improvements: https://github.com/rhasspy/piper-phonemize/pull/31

[danemadsen]

https://github.com/espeak-ng/espeak-ng/pull/1878

[bombless]

Where is the espeak_TextToPhonemesWithTerminator though, it's still missing in espeak-ng

[luispater]

Where is the espeak_TextToPhonemesWithTerminator though, it's still missing in espeak-ng

rhasspy/espeak-ng checkout this

[bombless]

Where is the espeak_TextToPhonemesWithTerminator though, it's still missing in espeak-ng

rhasspy/espeak-ng checkout this

Thank you for your reply! But I still cannot find it there https://github.com/search?q=repo%3Arhasspy%2Fespeak-phonemizer%20espeak_TextToPhonemesWithTerminator&type=code

[luispater]

Where is the espeak_TextToPhonemesWithTerminator though, it's still missing in espeak-ng

rhasspy/espeak-ng checkout this

Thank you for your reply! But I still cannot find it there https://github.com/search?q=repo%3Arhasspy%2Fespeak-phonemizer%20espeak_TextToPhonemesWithTerminator&type=code

This one? https://github.com/rhasspy/espeak-ng/blob/8593723f10cfd9befd50de447f14bf0a9d2a14a4/src/libespeak-ng/speech.c#L855

[bombless]

Where is the espeak_TextToPhonemesWithTerminator though, it's still missing in espeak-ng

rhasspy/espeak-ng checkout this

Thank you for your reply! But I still cannot find it there https://github.com/search?q=repo%3Arhasspy%2Fespeak-phonemizer%20espeak_TextToPhonemesWithTerminator&type=code

This one? https://github.com/rhasspy/espeak-ng/blob/8593723f10cfd9befd50de447f14bf0a9d2a14a4/src/libespeak-ng/speech.c#L855

Many many thanks for your reply! It helps a lot!

[luispater]

Where is the espeak_TextToPhonemesWithTerminator though, it's still missing in espeak-ng

rhasspy/espeak-ng checkout this

Thank you for your reply! But I still cannot find it there https://github.com/search?q=repo%3Arhasspy%2Fespeak-phonemizer%20espeak_TextToPhonemesWithTerminator&type=code

This one? https://github.com/rhasspy/espeak-ng/blob/8593723f10cfd9befd50de447f14bf0a9d2a14a4/src/libespeak-ng/speech.c#L855

Many many thanks for your reply! It helps a lot!

Just like me, I ignored the important information in the README.md. hahaha... “When using eSpeak phonemes, requires an espeak-ng fork with espeak_TextToPhonemesWithTerminator function. This function allows for Piper to preserve punctuation and detect sentence boundaries.”

[u1f35c]

In the hope of actually being able to use the system espeak rather than a patched variant, I've submitted a PR upstream to see if they'll accept it: https://github.com/espeak-ng/espeak-ng/pull/2127

Testing with a Debian setup and patching their package with this patch I can build piper-phonemize with the system espeak + onnxruntime rather than requiring the external versions.

[sthibaul]

The strange thing is that the prototype of TranslateClauseWithTerminator() made it upstream: espeak-ng/espeak-ng#1811

That's very odd that they merged the function prototype with no definition!

? It was just a normal really missing prototype: that was about TranslateClauseWithTerminator, not espeak_TextToPhonemesWithTerminator

[sthibaul]

I merged https://github.com/espeak-ng/espeak-ng/pull/2127 so this issue can be closed