rhai icon indicating copy to clipboard operation
rhai copied to clipboard

Silence some compiler warnings about unused imports

Open therealprof opened this issue 1 year ago • 3 comments

While trying something with the tests I noticed that there're some unused import warnings which can easily be silenced.

therealprof avatar Jul 16 '24 07:07 therealprof

Well, currently the coding style is that unused imports are OK in tests and other non-lib places.

You'll need to test most feature combinations to check if they're safe to remove... Although the tests show that it is safe...

Rhai has a large number of features and silencing all warnings will need to explicitly qualify a lot of things in lots of places.

We try to silence warnings for lib code so projects using Rhai won't get unnecessary compile warnings

schungx avatar Jul 17 '24 00:07 schungx

I do find the warnings very distracting as I was looking into improving the #899 situation and I'm also not attempting to fix the remaining 2 or 3 gnarlier ones. But I'm fine closing this PR if you don't want to address this cosmetic issue.

therealprof avatar Jul 17 '24 08:07 therealprof

Let's run the CI and see...

schungx avatar Jul 17 '24 09:07 schungx

Closing this for now.

schungx avatar Sep 30 '24 03:09 schungx