rhai icon indicating copy to clipboard operation
rhai copied to clipboard

Rhai depends on unmaintained crate "instant"

Open VorpalBlade opened this issue 1 year ago • 6 comments

According to https://crates.io/crates/instant:

This crate is no longer maintained. Please consider creating a fork or using web-time instead. Or reach out if you are interested in taking over its maintenance.

rhai should probably switch?

VorpalBlade avatar Jul 03 '24 07:07 VorpalBlade

Hhhhmmm.... good catch.

Not sure if web-time would be a drop-in replacement...

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

schungx avatar Jul 03 '24 07:07 schungx

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

Same, I was just adding rhai to a new project and was auditing the recursive dependencies it pulled in and noticed this. Since I don't target wasm I don't have any reason to work on this.

VorpalBlade avatar Jul 03 '24 07:07 VorpalBlade

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

If use web-time instead of instant, will it cause a breaking change?

0byteme avatar Aug 01 '24 11:08 0byteme

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

If use web-time instead of instant, will it cause a breaking change?

Not sure... I haven't used web-time before... can somebody test it out?

schungx avatar Aug 01 '24 12:08 schungx

Could we make pulling in time optional? We are currently thinking about adding Rhai support to graphite: https://github.com/GraphiteEditor/Graphite/pull/2460 but in our case we don't need time support at all so it would be great if we could just disable this altogether

TrueDoctor avatar Mar 20 '25 10:03 TrueDoctor

Try no_time?

schungx avatar Mar 21 '25 00:03 schungx